Fix NotImplementedError when eager loading BelongsToMany on a collection (#12)#21
Open
aleksanm wants to merge 1 commit into
Open
Fix NotImplementedError when eager loading BelongsToMany on a collection (#12)#21aleksanm wants to merge 1 commit into
aleksanm wants to merge 1 commit into
Conversation
…ev#12) Eager loading a BelongsToMany relationship onto a collection (Model.with_("rel").get()) raised NotImplementedError because BelongsToMany never overrode map_related. register_related already filters the related collection per-model, so map_related simply returns the result unchanged (matching HasOne). Adds a regression test asserting each parent keeps its own related set. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Eager loading a
BelongsToManyrelationship onto a collection (Model.with_("rel").get()) raisedNotImplementedErrorbecauseBelongsToManynever overrodemap_related. The single-model path (.first()) was unaffected, which is why it went unnoticed.register_relatedalready filters the related collection per-model, somap_relatedsimply returns the result unchanged (matchingHasOne). Added a regression test asserting each parent keeps its own related set.🤖 Generated with Claude Code